sdd commented on code in PR #476:
URL: https://github.com/apache/iceberg-rust/pull/476#discussion_r1715818692
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -504,8 +504,15 @@ impl Catalog for RestCatalog {
.query::<LoadTableResponse, ErrorResponse, OK>(request)
.await?;
+ let config = resp
+ .config
+ .unwrap_or_default()
+ .into_iter()
+ .chain(self.user_config.props.clone().into_iter())
Review Comment:
My rationale behind this was so that users _could_ override values from the
REST config. For instance if you wanted to try out using an S3 proxy / cache by
overriding the value of the S3 warehouse endpoint. I can change it if you
insist, but that would reduce the usefulness of this change in my eyes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
