flyrain commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1715740325
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -70,4 +70,10 @@ default RewritePositionDeleteFiles
rewritePositionDeletes(Table table) {
throw new UnsupportedOperationException(
this.getClass().getName() + " does not implement
rewritePositionDeletes");
}
+
+ /** Instantiates an action to copy table. */
+ default CopyTable copyTable(Table table) {
Review Comment:
We need to rename here as well
##########
api/src/main/java/org/apache/iceberg/actions/RewriteTableLocation.java:
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.actions;
+
+import org.apache.iceberg.Table;
+
+public interface RewriteTableLocation extends Action<RewriteTableLocation,
RewriteTableLocation.Result> {
Review Comment:
I'd try to avoid using the name `TableLocation`, which is a dedicated name
for the location of the table as a table property. Given the action is to
rewrite the file paths within all metadata files, is `rewriteFilePath` more
suitable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
