amitgilad3 commented on code in PR #1036:
URL: https://github.com/apache/iceberg-python/pull/1036#discussion_r1714382905
##########
pyiceberg/table/__init__.py:
##########
@@ -621,6 +621,13 @@ def delete(self, delete_filter: Union[str,
BooleanExpression], snapshot_properti
if not delete_snapshot.files_affected and not
delete_snapshot.rewrites_needed:
warnings.warn("Delete operation did not match any records")
+ def find_referenced_files(self, file_paths: List[str]) -> list[str]:
Review Comment:
you are right, it makes more sense to move it into the logic into add_files
since no one uses it and its on 3 lines if code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
