ajantha-bhat commented on code in PR #10246:
URL: https://github.com/apache/iceberg/pull/10246#discussion_r1713869763
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -156,6 +156,8 @@ public List<ManifestFile> apply(TableMetadata base,
Snapshot snapshot) {
manifests.addAll(snapshot.allManifests(ops.io()));
}
+ manifests.forEach(summaryBuilder::addedManifestStats);
Review Comment:
> I'm still thinking the argument of having this information helping the
query planning is quite thin
Thanks. We will try out this change in our fork and benchmark the results
with and without this change for our engine (Dremio). So, we will have a clear
understanding of the benefits of these changes.
The other engines that has CBO like Trino can also try it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
