liurenjie1024 commented on code in PR #531:
URL: https://github.com/apache/iceberg-rust/pull/531#discussion_r1711072296
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -649,178 +649,106 @@ mod tests {
use super::*;
use crate::spec::Schema;
+ /**
+ * Create a simple field with metadata.
+ */
+ fn simple_field(name: &str, ty: DataType, nullable: bool, value: &str) ->
Field {
+ Field::new(name, ty, nullable).with_metadata(HashMap::from([(
+ PARQUET_FIELD_ID_META_KEY.to_string(),
+ value.to_string(),
+ )]))
+ }
+
fn arrow_schema_for_arrow_schema_to_schema_test() -> ArrowSchema {
let fields = Fields::from(vec![
- Field::new("key", DataType::Int32,
false).with_metadata(HashMap::from([(
- PARQUET_FIELD_ID_META_KEY.to_string(),
- "17".to_string(),
- )])),
- Field::new("value", DataType::Utf8,
true).with_metadata(HashMap::from([(
- PARQUET_FIELD_ID_META_KEY.to_string(),
- "18".to_string(),
- )])),
+ simple_field("key", DataType::Int32, false, "17"),
Review Comment:
+1, we can have a method to add single metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
