skytin1004 commented on code in PR #10884: URL: https://github.com/apache/iceberg/pull/10884#discussion_r1709389878
########## hive-runtime/NOTICE: ########## @@ -42,11 +42,11 @@ NOTICE file: | * Redistributions of source code must retain the above copyright | notice, this list of conditions and the following disclaimer. | * Redistributions in binary form must reproduce the above -| copyright notice, this list of conditions and the following disclaimer -| in the documentation and/or other materials provided with the +| copyright notice, this list of conditions, and the following disclaimer +| In the documentation and/or other materials provided with the Review Comment: ```suggestion | in the documentation and/or other materials provided with the ``` I think it would be better to leave this part as it is rather than start a new sentence. ########## README.md: ########## @@ -1,4 +1,4 @@ -<!-- +Spark, Flink and<!-- Review Comment: It seems to be a typo. This part needs to be reverted to its original state. ########## hive-runtime/NOTICE: ########## @@ -42,11 +42,11 @@ NOTICE file: | * Redistributions of source code must retain the above copyright | notice, this list of conditions and the following disclaimer. | * Redistributions in binary form must reproduce the above -| copyright notice, this list of conditions and the following disclaimer -| in the documentation and/or other materials provided with the +| copyright notice, this list of conditions, and the following disclaimer +| In the documentation and/or other materials provided with the | distribution. | * Neither the name of Google Inc. nor the names of its -| contributors may be used to endorse or promote products derived from +| Contributors may be used to endorse or promote products derived from Review Comment: ```suggestion | contributors may be used to endorse or promote products derived from ``` I think it would be better to leave this part as it is rather than start a new sentence. ########## open-api/README.md: ########## @@ -1,21 +1,21 @@ <!-- - - Licensed to the Apache Software Foundation (ASF) under one - - or more contributor license agreements. See the NOTICE file - - distributed with this work for additional information - - regarding copyright ownership. The ASF licenses this file - - to you under the Apache License, Version 2.0 (the - - "License"); you may not use this file except in compliance - - with the License. You may obtain a copy of the License at - - - - http://www.apache.org/licenses/LICENSE-2.0 - - - - Unless required by applicable law or agreed to in writing, - - software distributed under the License is distributed on an - - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - - KIND, either express or implied. See the License for the - - specific language governing permissions and limitations - - under the License. - --> + - Licensed to the Apache Software Foundation (ASF) under one + - or more contributor license agreements. See the NOTICE file + - distributed with this work for additional information + - regarding copyright ownership. The ASF licenses this file + - to you under the Apache License, Version 2.0 (the + - "License"); you may not use this file except in compliance + - with the License. You may obtain a copy of the License at + - + - http://www.apache.org/licenses/LICENSE-2.0 + - + - Unless required by applicable law or agreed to in writing, + - software distributed under the License is distributed on an + - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + - KIND, either express or implied. See the License for the + - specific language governing permissions and limitations + - under the License. Review Comment: The phrase "Licensed to the Apache Software Foundation (ASF)" should be identical across all instances. Please ensure it matches the provided version below: ``` <!-- - Licensed to the Apache Software Foundation (ASF) under one - or more contributor license agreements. See the NOTICE file - distributed with this work for additional information - regarding copyright ownership. The ASF licenses this file - to you under the Apache License, Version 2.0 (the - "License"); you may not use this file except in compliance - with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, - software distributed under the License is distributed on an - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - KIND, either express or implied. See the License for the - specific language governing permissions and limitations - under the License. --> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
