amogh-jahagirdar commented on code in PR #10898:
URL: https://github.com/apache/iceberg/pull/10898#discussion_r1707758990
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -107,7 +107,13 @@ public static void afterClass() throws Exception {
ScheduledThreadPoolExecutor executor =
((ScheduledThreadPoolExecutor)
validatingSigner.icebergSigner.tokenRefreshExecutor());
- // token expiration is set to 100s so there should be exactly one token
scheduled for refresh
+ // token expiration is set to 10000s so there should be exactly one token
scheduled for refresh.
Review Comment:
Could we link or somehow reference the S3SignerServlet class in this
comment? That's where it's actually set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
