nastra commented on code in PR #10899:
URL: https://github.com/apache/iceberg/pull/10899#discussion_r1707196585
##########
core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java:
##########
@@ -104,7 +104,7 @@ public ViewMetadata refresh() {
@Override
public void commit(ViewMetadata base, ViewMetadata metadata) {
// if the metadata is already out of date, reject it
- if (base != current()) {
+ if (!current().equals(base)) {
Review Comment:
the previous check is actually correct
##########
core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java:
##########
@@ -115,7 +115,7 @@ public void commit(ViewMetadata base, ViewMetadata
metadata) {
}
// if the metadata is not changed, return early
- if (base == metadata) {
+ if (metadata.equals(base)) {
Review Comment:
the previous check is actually correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
