FANNG1 commented on code in PR #10862:
URL: https://github.com/apache/iceberg/pull/10862#discussion_r1706240127
##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -705,13 +705,13 @@ public void testMixedChanges() {
.renameColumn("points.x", "X")
.renameColumn("points.y", "y.y") // has a '.' in the field name
.updateColumn("id", Types.LongType.get(), "unique id")
- .updateColumn("locations.lat", Types.DoubleType.get()) // use the
original name
- .updateColumnDoc("locations.lat", "latitude")
+ .updateColumn("latitude", Types.DoubleType.get()) // use the
renamed name
Review Comment:
It's more proper to update the renamed name not original name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
