nastra commented on code in PR #10861: URL: https://github.com/apache/iceberg/pull/10861#discussion_r1705020634
########## core/src/test/java/org/apache/iceberg/TestFormatVersions.java: ########## @@ -28,51 +28,79 @@ public class TestFormatVersions extends TestBase { @Parameters(name = "formatVersion = {0}") protected static List<Object> parameters() { - return Arrays.asList(1); + return Arrays.asList(1, 2); } @TestTemplate public void testDefaultFormatVersion() { Review Comment: the test should be added back and updated to ``` @TestTemplate public void testDefaultFormatVersion() { assertThat(table.ops().current().formatVersion()).isEqualTo(formatVersion); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org