nastra commented on code in PR #10861:
URL: https://github.com/apache/iceberg/pull/10861#discussion_r1704495785
##########
core/src/test/java/org/apache/iceberg/TestUpdateRequirements.java:
##########
@@ -199,7 +199,21 @@ public void upgradeFormatVersion() {
}
@Test
- public void upgradeFormatVersionForView() {
+ public void upgradeFormatVersionV3() {
Review Comment:
so technically you don't need to add a new test. I'd probably just slightly
adjust `upgradeFormatVersion()` and make it a parameterized test:
```
@ParameterizedTest
@ValueSource(ints = {2, 3}
public void upgradeFormatVersionTo(int version) {...}
```
I'd then do the same pattern for `upgradeFormatVersionForView()`:
```
@ParameterizedTest
@ValueSource(ints = {2, 3}
public void upgradeFormatVersionForViewTo(int version) {...}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
