Xuanwo commented on code in PR #518: URL: https://github.com/apache/iceberg-rust/pull/518#discussion_r1704205451
########## Cargo.toml: ########## @@ -18,11 +18,14 @@ [workspace] resolver = "2" members = [ - "crates/catalog/*", - "crates/examples", - "crates/iceberg", - "crates/integrations/*", - "crates/test_utils", + "crates/catalog/*", + "crates/examples", + "crates/iceberg", + "crates/integrations/*", + "crates/test_utils", +] +exclude = [ Review Comment: > Why we need to exclude this? The `bindings/python` is not in the same workspace as the entire iceberg-rust project because it requires extra setup for contributors. I hope that only those interested in development should invest effort in this setup. This also makes our CI must easier to maintian. For examples, `cargo clippy --workspace` won't fail because of missing `libpython-dev`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
