ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1703112487
##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -51,6 +69,8 @@ public StandardEncryptionManager(
this.tableKeyId = tableKeyId;
this.kmsClient = kmsClient;
this.dataKeyLength = dataKeyLength;
+ this.kekCacheTimeout = kekCacheTimeout;
+ this.kekCache = Maps.newHashMap();
Review Comment:
Probably `kekCacheTimeout` is not an accurate name - the parameter basically
means how long we can use a KEK in the writer, before we need to generate a new
one. I'll rename it.
We need previous keys in the cache, so that readers don't call the KMS again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
