yeezychao commented on issue #10219: URL: https://github.com/apache/iceberg/issues/10219#issuecomment-2265099106
> Maybe we could just implement the interface with the `IcebergTableSource`. We either prevent setting a watermark strategy which is not `noWatermarks` (cleaner approach, but might not work, if the watermark strategy is reused somewhere else to change some behavior), or create a new watermark strategy in `createFLIP27Stream`, where the watermark generation part is `noWatermark`, and only the timestamp generation part is reused. If we pass this watermark strategy to the `fromSource`, then we might be able to make things work. > > Sadly I don't have the bandwidth to test this out, but if you want to take a stab at it, I can review your PR. > > Thanks, Peter I refer to [4625](https://github.com/apache/iceberg/pull/4625) and implement the computed column and declare the watermark strategy. I plan to align the logic of your implemented `watermark-column` option in IcebergSource code according to the watermark field stored in the table attributes. But if the `watermark-column` is a computed column (not a physical column), how to create `SplitWatermarkExtractor` next? Can you give me some advice? Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
