advancedxy commented on code in PR #10846:
URL: https://github.com/apache/iceberg/pull/10846#discussion_r1701101759
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2567,6 +2568,21 @@ components:
type: integer
format: int64
+ RemovePartitionSpecsUpdate:
+ allOf:
+ - $ref: '#/components/schemas/BaseUpdate'
+ required:
+ - spec-ids
+ properties:
+ action:
+ type: string
+ enum: [ "remove-partition-specs" ]
+ spec-ids:
+ type: array
+ items:
+ type: integer
+ format: int64
Review Comment:
I think specId is a integer/int, should not have the int64 format?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2265,6 +2265,7 @@ components:
remove-statistics: '#/components/schemas/RemoveStatisticsUpdate'
set-partition-statistics:
'#/components/schemas/SetPartitionStatisticsUpdate'
remove-partition-statistics:
'#/components/schemas/RemovePartitionStatisticsUpdate'
+ remove-partition-specs:
'#/components/schemas/RemovePartitionSpecsUpdate'
Review Comment:
how about `remove-unused-partitioned-specs`/`remove-unused-specs`,
emphasizing the `unused` part?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2567,6 +2568,21 @@ components:
type: integer
format: int64
+ RemovePartitionSpecsUpdate:
+ allOf:
+ - $ref: '#/components/schemas/BaseUpdate'
+ required:
+ - spec-ids
+ properties:
+ action:
+ type: string
+ enum: [ "remove-partition-specs" ]
+ spec-ids:
+ type: array
+ items:
+ type: integer
+ format: int64
Review Comment:
I think specId is a integer/int, should not have the int64 format?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2265,6 +2265,7 @@ components:
remove-statistics: '#/components/schemas/RemoveStatisticsUpdate'
set-partition-statistics:
'#/components/schemas/SetPartitionStatisticsUpdate'
remove-partition-statistics:
'#/components/schemas/RemovePartitionStatisticsUpdate'
+ remove-partition-specs:
'#/components/schemas/RemovePartitionSpecsUpdate'
Review Comment:
By the way, I'm neutral about the name, this name is more general and
expresses the intention well.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2567,6 +2568,21 @@ components:
type: integer
format: int64
+ RemovePartitionSpecsUpdate:
+ allOf:
+ - $ref: '#/components/schemas/BaseUpdate'
+ required:
+ - spec-ids
+ properties:
+ action:
+ type: string
+ enum: [ "remove-partition-specs" ]
+ spec-ids:
+ type: array
+ items:
+ type: integer
+ format: int64
Review Comment:
I think specId is a integer/int, should not have the int64 format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
