sungwy commented on code in PR #986: URL: https://github.com/apache/iceberg-python/pull/986#discussion_r1700673759
########## tests/io/test_pyarrow_visitor.py: ########## @@ -596,6 +597,11 @@ def test_pyarrow_schema_ensure_large_types(pyarrow_schema_nested_without_ids: pa assert _pyarrow_schema_ensure_large_types(pyarrow_schema_nested_without_ids) == expected_schema +def test_pyarrow_schema_ensure_small_types(pyarrow_schema_nested_without_ids: pa.Schema) -> None: + schema_with_large_types = _pyarrow_schema_ensure_small_types(pyarrow_schema_nested_without_ids) Review Comment: This was for testing the roundtrip conversion - fixed it to use the correct function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org