stevenzwu commented on code in PR #10832:
URL: https://github.com/apache/iceberg/pull/10832#discussion_r1699246487
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -545,5 +579,66 @@ public IcebergSource<T> build() {
table,
emitter);
}
+
+ /**
+ * Build the {@link IcebergSource} and create a {@link DataStream} from
the source.
+ *
+ * @return data stream from the Iceberg source
+ */
+ public DataStream<T> buildStream(StreamExecutionEnvironment env) {
Review Comment:
This is a new public API. I also thought about the method name as
`createStream`. but decided this name for now. open to other suggestion.
also think it is better to require `StreamExecutionEnvironment` here instead
of having it a builder method so that it is clear it is not required for the
`build()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
