RussellSpitzer commented on code in PR #10760:
URL: https://github.com/apache/iceberg/pull/10760#discussion_r1699026456
##########
core/src/main/java/org/apache/iceberg/ManifestLists.java:
##########
@@ -66,6 +66,9 @@ static ManifestListWriter write(
case 2:
return new ManifestListWriter.V2Writer(
manifestListFile, snapshotId, parentSnapshotId, sequenceNumber);
+ case 3:
+ return new ManifestListWriter.V3Writer(
+ manifestListFile, snapshotId, parentSnapshotId, sequenceNumber);
Review Comment:
Yeah I was figuring for now we keep things the same as between V1 and V2,
also protects us a little more from inadvertently breaking V2 as we begin
mucking about with V3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
