RussellSpitzer commented on code in PR #10774:
URL: https://github.com/apache/iceberg/pull/10774#discussion_r1698695842
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSetWriteDistributionAndOrdering.java:
##########
@@ -249,6 +267,13 @@ public void testSetWriteDistributedByWithLocalSort() {
SortOrder expected =
SortOrder.builderFor(table.schema()).withOrderId(1).asc("id").build();
assertThat(table.sortOrder()).as("Sort order must
match").isEqualTo(expected);
+
+ sql("ALTER TABLE %s WRITE LOCALLY ORDERED BY id", tableName);
+
+ table.refresh();
+
+ String newDistributionMode =
table.properties().get(TableProperties.WRITE_DISTRIBUTION_MODE);
+ assertThat(newDistributionMode).as("Distribution mode must
match").isEqualTo("hash");
Review Comment:
rather than checking against hash here we should get the distribution mode
before calling "alter" and compare against that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
