pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1698256343
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/ManifestOutputFileFactory.java:
##########
@@ -41,6 +42,19 @@ class ManifestOutputFileFactory {
private final long attemptNumber;
private final AtomicInteger fileCount = new AtomicInteger(0);
+ public ManifestOutputFileFactory(
+ Supplier<Table> tableSupplier,
+ Map<String, String> props,
+ String flinkJobId,
+ String operatorId) {
+ this.tableSupplier = tableSupplier;
+ this.props = props;
+ this.flinkJobId = flinkJobId;
+ this.operatorUniqueId = operatorId;
+ this.subTaskId = 0;
Review Comment:
I think we can use `getRuntimeContext().getAttemptNumber()` from the
`IcebergWriteAggregator.open` to get the required parameters, and then we don't
need to use hardcoded values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
