kevinjqliu commented on code in PR #983:
URL: https://github.com/apache/iceberg-python/pull/983#discussion_r1697756436


##########
mkdocs/docs/how-to-release.md:
##########
@@ -243,3 +252,13 @@ Make sure to create a PR to update the [GitHub issues 
template](https://github.c
 ## Update the integration tests
 
 Ensure to update the `PYICEBERG_VERSION` in the 
[Dockerfile](https://github.com/apache/iceberg-python/blob/main/dev/Dockerfile).
+
+## Create a Github Release Note
+
+First, follow the directions for Setting the tag again to create a tag for the 
approved release version (e.g. `0.7.0`).
+
+Then, create a new [Release 
Note](https://github.com/apache/iceberg-python/releases) on the iceberg-python 
Github repository by clicking on **Draft a New Release**.

Review Comment:
   might be easier to link https://github.com/apache/iceberg-python/releases/new



##########
mkdocs/docs/how-to-release.md:
##########
@@ -243,3 +252,13 @@ Make sure to create a PR to update the [GitHub issues 
template](https://github.c
 ## Update the integration tests
 
 Ensure to update the `PYICEBERG_VERSION` in the 
[Dockerfile](https://github.com/apache/iceberg-python/blob/main/dev/Dockerfile).
+
+## Create a Github Release Note
+
+First, follow the directions for Setting the tag again to create a tag for the 
approved release version (e.g. `0.7.0`).
+
+Then, create a new [Release 
Note](https://github.com/apache/iceberg-python/releases) on the iceberg-python 
Github repository by clicking on **Draft a New Release**.

Review Comment:
   I think we also need to set the "Previous tag" before clicking "Generate 
release notes", `auto` seems to generate notes for all commits



##########
mkdocs/docs/how-to-release.md:
##########
@@ -243,3 +252,13 @@ Make sure to create a PR to update the [GitHub issues 
template](https://github.c
 ## Update the integration tests
 
 Ensure to update the `PYICEBERG_VERSION` in the 
[Dockerfile](https://github.com/apache/iceberg-python/blob/main/dev/Dockerfile).
+
+## Create a Github Release Note
+
+First, follow the directions for Setting the tag again to create a tag for the 
approved release version (e.g. `0.7.0`).

Review Comment:
   I think it's possible to auto-create a tag with a release note
   
   ![Screenshot 2024-07-30 at 5 41 43 
PM](https://github.com/user-attachments/assets/a4bb8fab-90c2-41b0-bf3a-48de5564c4d3)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to