amogh-jahagirdar opened a new pull request, #10820: URL: https://github.com/apache/iceberg/pull/10820
This can be considered as an alternative to https://github.com/apache/iceberg/pull/10724 In #10724, a new API on the DataFile builder was proposed which enabled callers to pass in custom partition string conversion functions. The rationale behind that API was that Iceberg should not be opinionated on how to do the conversion, and `Conversions` utility primarily existed for enabling Hive style table migrations. Callers could pass in whatever they wanted. The use case that was driving #10724 was to enable Delta uniform to be be able to have timestamp partitions. Since the `Conversions` utility already doesn't support timestamps, and maybe the proposed API isn't really needed beyond the uniform use-case, this approach just adds the handling the timestamp partitioning. Specifically, handling expects an ISO8601 UTC adjusted instant. Anything else will fail parsing in the conversion. The conversion logic for timestamp returns a microseconds since epoch long that aligns with what the Iceberg data type representation is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
