rodmeneses commented on PR #10776: URL: https://github.com/apache/iceberg/pull/10776#issuecomment-2253132273
> @rodmeneses: IIRC we faced an issue in the tests when we were introducing Flink 1.19. This was solved by adding the `dropDatabase` to the tests. We found that it would be good to have a better cleanup method for every tests which uses FlinkSQL, but decided against adding that along with the 1.19 PR. This basically resulted in "inconsistencies" between the 1.17-1.18/1.19 tests. > > If my recollection above is correct, then we have 2 tasks ahead of us: > > 1. This PR doesn't need to add the `dropDatabase` related changes to the backports > 2. We still need to come up with a better cleanup for the SQL tests > > @rodmeneses: Could you please confirm? > > Thanks, Peter that is correct @pvary. We discussed about having a more thorough cleaning logic for all of FlinkSQL related unit tests, but I didn't have the time nor I wanted to keep adding more complexity on my previous PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
