rdblue commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1693336001
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3647,6 +3826,151 @@ components:
type: integer
description: "List of equality field IDs"
+ DeleteFile:
+ oneOf:
+ - $ref: '#/components/schemas/PositionDeleteFile'
+ - $ref: '#/components/schemas/EqualityDeleteFile'
+
+ PreplanTableRequest:
+ type: object
+ oneOf:
+ - required:
+ - snapshot-id
+ - required:
+ - start-snapshot-id
Review Comment:
I think a clean way of expressing mutually exclusive fields is to use the
context structure that Jack introduced. Then just use `allOf` to incorporate
the context into the request rather than adding it as a `scan-context` field.
Alternatively, we could make them optional in OpenAPI and document that you
must send either `snapshot-id` or `start-snapshot-id` and `end-snapshot-id`. I
don't have a problem with that since there isn't a very simple way to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
