liurenjie1024 commented on code in PR #331:
URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1692652244
##########
crates/iceberg/src/spec/view_version.rs:
##########
@@ -71,8 +74,18 @@ impl ViewVersion {
/// Get the timestamp of when the view version was created
#[inline]
- pub fn timestamp(&self) -> MappedLocalTime<DateTime<Utc>> {
- Utc.timestamp_millis_opt(self.timestamp_ms)
+ pub fn timestamp(&self) -> Result<DateTime<Utc>> {
+ match Utc.timestamp_millis_opt(self.timestamp_ms) {
Review Comment:
I think the `MappedLocalTime` is somehow another kind of result with extra
values, so putting it in error module seems fine to me. Also it's not a public
api, so we wil be able to change it in future if we have better solutions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
