sl255051 commented on PR #10678: URL: https://github.com/apache/iceberg/pull/10678#issuecomment-2248955661
@RussellSpitzer @amogh-jahagirdar I understand your position on case sensitivity. Given that position it seems to me that PartitionSpec.java does not enable case-insensitivity because the current implementation of that class does not provide a way to call Schema.java's case-insensitive helper methods. For example the PartitionSpec.Builder.Identity method currently can only search for schema columns in a case-sensitive manner even though Schema offers case-insensitive methods for finding columns. One solution would be to add lots of method overloads, e.g. `PartitionSpec.Builder.Identity(String, String)` and `PartitionSpec.Builder.caseInsensitiveIdentity(String, String)` or `PartitionSpec.Builder.Identity(String, String, Boolean)`. This solution seems rather unattractive because it would increase the class's footprint and create noise thus making the class at least a little bit harder to grok. Or is the solution as simple as saying PartitionSpec and PartitionSpec.Builder are case-sensitive and there are no convenience methods for supporting case-insensitivity? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
