liurenjie1024 commented on code in PR #331:
URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1688104381


##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -332,7 +332,7 @@ impl TableMetadataBuilder {
 
         let table_metadata = TableMetadata {
             format_version: FormatVersion::V2,
-            table_uuid: Uuid::new_v4(),
+            table_uuid: Uuid::now_v7(),

Review Comment:
   Thanks @c-thiel for clear explaination. I wasn't aware of their difference, 
and I believe the pros of v4 is not solid reason. I'm quite convinced by the 
benificials of v7, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to