RussellSpitzer commented on code in PR #10724:
URL: https://github.com/apache/iceberg/pull/10724#discussion_r1686839951
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -259,11 +268,19 @@ public Builder withFileSizeInBytes(long
newFileSizeInBytes) {
}
public Builder withPartitionPath(String newPartitionPath) {
+ return withPartitionPath(newPartitionPath,
DEFAULT_PARTITION_STRING_CONVERSION);
+ }
+
+ public Builder withPartitionPath(
+ String newPartitionPath, BiFunction<String, Type, Object>
partitionPathConverter) {
Review Comment:
Any system's we are thinking about here? I know we are pretty much good for
Hive now, do we have custom apps we are trying to support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
