zhongyujiang commented on PR #10567: URL: https://github.com/apache/iceberg/pull/10567#issuecomment-2243048745
> I can see 2 ways to fix this: > > Count every file in the fileOffset - even the ones which are skipped. This seems more natural to me, but the state need to be converted > Count only the non-skipped files in the fileOffset - even when restoring the state. This is the fix you have provided, and the state doesn't change in this case. In fact, my fix was the first approach, as I removed the erroneous assignment at the end of the `seek()` method. Now, within `updateCurrentIterator()`, even if a file is skipped, `fileOffset` will still be incremented by 1 correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
