flyrain commented on PR #10621: URL: https://github.com/apache/iceberg/pull/10621#issuecomment-2234385889
Thanks @jackye1995. I like the approach a lot overall. The abstraction is reasonable. The only concern is about how much we can abstract from different authentication methods. Things to consider like what if the authentication doesn't need refresh or it doesn't just deal with headers as @adutra and @amogh-jahagirdar already mentioned. Unfortunately, I'm not familiar with other authentication methods, like kerberos via HTTP. I hope people with related expertise can chime in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
