RussellSpitzer commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1678282002
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -136,19 +151,25 @@ private boolean checkTasks() {
}
}
- return !closed && (tasks.hasNext() || hasRunningTask);
+ return !closed.get() && (tasks.hasNext() || hasRunningTask);
}
- private Future<?> submitNextTask() {
- if (!closed && tasks.hasNext()) {
- return workerPool.submit(tasks.next());
+ private Future<Optional<Task<T>>> submitNextTask() {
+ if (!closed.get()) {
+ if (!yieldedTasks.isEmpty()) {
+ return workerPool.submit(yieldedTasks.removeFirst());
+ }
Review Comment:
nit: combine this into
If / else if
to avoid the implicit If else if caused by the dual returns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
