szehon-ho commented on PR #10445: URL: https://github.com/apache/iceberg/pull/10445#issuecomment-2227037227
@danielcweeks @tabmatfournier while we are discussing, do you guys think it makes sense later to integrate my functionality into this Repair action? its been awhile, but iirc it was about fixing the manifest metadata (ie, file sizes, and metrics). File sizes to fix a bug https://github.com/apache/iceberg/issues/1980 that at the time seemed important, but its probably rare. Re-calculating metrics based on new table configs is a more common case. Ive seen a lot of users with huge metadatas that OOM planning, and realize they need to tune to reduce metrics collected, and so far there's no mechanism to do this. Another option for these is additonal flag on RewriteManifests, but I think there were some opinions in #2608 that it should be a separate action as rewrite indicates, rewrite-as-is. If we agree, I can add these funcitons in a follow up. Maybe it makes sense to have a bit array of options, as it seems Repair has many options then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
