c-thiel commented on code in PR #331:
URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1676794013
##########
crates/iceberg/testdata/view_metadata/ViewMetadataV2Valid.json:
##########
@@ -0,0 +1,58 @@
+{
Review Comment:
Ok, thanks Eduard for the Feedback.
My preferred way of going forward would be:
1. Merge this PR which just contains the structs & (de)serialization (very
much like the `TableMetadaData` in its current state)
2. Figure out a good way for the `TableMetadataBuilder` including partition
binding. We have a first shot ready that we can create a PR for.
3. Use the same pattern we use for the `TableMetadataBuilder` for the much
lighter `ViewMetadataBuilder` which then includes all the tests Eduard
mentioned.
I am aware that a lot of things are missing in the builder. It was a
deliberate decision from me to get views up-to-speed with tables first, and
then in a second step extend both tables and views features to the java level.
This way we have a handleable PR here that just takes care or (ser)de and can
build on it in a next step.
@ZENOTME , @nastra would that be OK for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
