szehon-ho commented on code in PR #10647:
URL: https://github.com/apache/iceberg/pull/10647#discussion_r1674895594
##########
docs/docs/spark-ddl.md:
##########
@@ -245,7 +246,8 @@ ALTER TABLE prod.db.sample
ADD COLUMN points.value.b int;
```
-Note: Altering a map 'key' column by adding columns is not allowed. Only map
values can be updated.
+!!! note
Review Comment:
These look unrelated, how about another pr?
##########
docs/docs/spark-ddl.md:
##########
@@ -425,6 +427,9 @@ To order within each task, not across tasks, use `LOCALLY
ORDERED BY`:
ALTER TABLE prod.db.sample WRITE LOCALLY ORDERED BY category, id
```
+!!! note
+ Write distribution of `hash` will be changed to `none` by this. Please use
`ALTER TABLE .. WRITE DISTRIBUTED BY PARTITION LOCALLY ORDERED BY` to preserve
the write distribution.
Review Comment:
How about just ```This will request a write distribution of `none`.```
Not sure if the other parts are necessary, if they are mentioned below?
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSetWriteDistributionAndOrdering.java:
##########
@@ -213,6 +213,26 @@ public void testSetWriteLocallyOrdered() {
assertThat(table.sortOrder()).as("Sort order must
match").isEqualTo(expected);
}
+ @TestTemplate
+ public void testSetWriteLocallyOrderedWithDistribution() {
Review Comment:
isnt it withoutDistribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
