ajantha-bhat commented on code in PR #10643:
URL: https://github.com/apache/iceberg/pull/10643#discussion_r1672702549
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -70,4 +70,10 @@ default RewritePositionDeleteFiles
rewritePositionDeletes(Table table) {
throw new UnsupportedOperationException(
this.getClass().getName() + " does not implement
rewritePositionDeletes");
}
+
+ /** Instantiates an action to remove expired files. */
+ default RemoveExpiredFiles removeExpiredFiles(Table table) {
Review Comment:
> Yes, the existing remove orphan files can clean those left over files, but
it is very expensive, especially for S3.
Ack. I think instead of separate action, copy table action should atomically
clean up its orphan files also. This way it will be less confusing for users
and one less action to remember. Lets see what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
