nastra commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1672474232
##########
api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java:
##########
@@ -165,6 +159,68 @@ public void testLong() {
.isEqualTo(hashBytes(buffer.array()));
}
+ @Test
+ public void testTimestampNanoPromotion() {
+ // Values from spec Appendix B: 32-bit Hash Requirements
+ String timestamp1 = "2017-11-16T22:31:08";
Review Comment:
I think it would make sense to inline all of the timestamps / hashes as it
makes reading the test much easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
