liurenjie1024 commented on code in PR #441:
URL: https://github.com/apache/iceberg-rust/pull/441#discussion_r1672261330
##########
.github/workflows/ci.yml:
##########
@@ -95,7 +100,12 @@ jobs:
run: cargo build -p iceberg --no-default-features
unit:
- runs-on: ubuntu-latest
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os:
+ - ubuntu-latest
+ - macos-latest
Review Comment:
Sorry I was wrong about the failure on macos. It seems that github action's
provided macos has no docker installation, which is relied on by our test, so
we should remove this part.
##########
.github/workflows/ci.yml:
##########
@@ -34,7 +34,12 @@ env:
jobs:
check:
- runs-on: ubuntu-latest
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os:
+ - ubuntu-latest
+ - macos-latest
Review Comment:
Could we add this for windows-latest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
