lurnagao-dahua commented on PR #10661: URL: https://github.com/apache/iceberg/pull/10661#issuecomment-2220192044
@zhangbutao @deniskuzZ Thank you for your attention to this issue! After a long period of consideration, I believe it is not ideal to directly validate the fix for the following reasons: 1.The getSplits method is only for querying and does not record ugi information. The workerpool will be closed after it is used, so it is not possible to access the thread pool in the test case. 2.The planInputSplits method is of private type and not visible to the tests. 3.The unit tests are running on the local file system, where the user performing file read/write operations is the process user, not the ugi. Therefore, it is not possible to validate based on permissions. Therefore, the unit test I added is directly testing the effect of enabling the new workerpool. May I ask if someone could help me check my use cases? I would greatly appreciate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
