syun64 commented on code in PR #848: URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1671326003
########## pyiceberg/catalog/__init__.py: ########## @@ -675,8 +675,11 @@ def _convert_schema_if_needed(schema: Union[Schema, "pa.Schema"]) -> Schema: from pyiceberg.io.pyarrow import _ConvertToIcebergWithoutIDs, visit_pyarrow + downcast_ns_timestamp_to_us = Config().get_bool("downcast-ns-timestamp-to-us-on-write") or False Review Comment: Thank you for the review! I've adopted this in the new commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org