lurnagao-dahua commented on code in PR #10661:
URL: https://github.com/apache/iceberg/pull/10661#discussion_r1669953742
##########
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -144,21 +147,32 @@ public List<InputSplit> getSplits(JobContext context) {
InputFormatConfig.InMemoryDataModel model =
conf.getEnum(
InputFormatConfig.IN_MEMORY_DATA_MODEL,
InputFormatConfig.InMemoryDataModel.GENERIC);
- try (CloseableIterable<CombinedScanTask> tasksIterable = scan.planTasks())
{
- Table serializableTable = SerializableTable.copyOf(table);
- tasksIterable.forEach(
- task -> {
- if (applyResidual
- && (model == InputFormatConfig.InMemoryDataModel.HIVE
- || model == InputFormatConfig.InMemoryDataModel.PIG)) {
- // TODO: We do not support residual evaluation for HIVE and PIG
in memory data model
- // yet
- checkResiduals(task);
- }
- splits.add(new IcebergSplit(serializableTable, conf, task));
- });
- } catch (IOException e) {
- throw new UncheckedIOException(String.format("Failed to close table
scan: %s", scan), e);
+ final ExecutorService workerPool =
+ ThreadPools.newWorkerPool(
+ "iceberg-plan-worker-pool",
+ conf.getInt(
+ SystemConfigs.WORKER_THREAD_POOL_SIZE.propertyKey(),
+ ThreadPools.WORKER_THREAD_POOL_SIZE));
+ try {
+ scan = scan.planWith(workerPool);
Review Comment:
> ```
> set hive.fetch.task.conversion=more;
> B user execution query select * from iceberg_tb_b;
> A user execution query select * from iceberg_tb_a;
> ```
>
> @lurnagao-dahua, could you please refactor code to be in sync with
[apache/hive@45867be](https://github.com/apache/hive/commit/45867be6cb5308566e4cf16c7b4cf8081085b58c)
Hi, Do you mean adjusting the code style for iceberg, such as adding methods
like planInputSplits and applyConfig,etc or just planInputSplits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
