jacobmarble commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1669413492
##########
api/src/test/java/org/apache/iceberg/expressions/TestStringLiteralConversions.java:
##########
@@ -181,17 +226,30 @@ public void testNegativeStringToTimestampLiteral() {
@Test
public void testTimestampWithZoneWithoutZoneInLiteral() {
// Zone must be present in literals when converting to timestamp with zone
- Literal<CharSequence> timestampStr = Literal.of("2017-08-18T14:21:01.919");
- assertThatThrownBy(() -> timestampStr.to(Types.TimestampType.withZone()))
+ assertThatThrownBy(
+ () ->
Literal.of("2017-08-18T14:21:01.919123").to(Types.TimestampType.withZone()))
Review Comment:
This wasn't a technically necessary change, but it does make
human-readability slightly easier by matching "microseconds" with six digits,
and "nanoseconds" with nine digits. I made this change in several places, all
for the same reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
