amogh-jahagirdar commented on code in PR #10580:
URL: https://github.com/apache/iceberg/pull/10580#discussion_r1664908939


##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java:
##########
@@ -422,7 +422,7 @@ public TimestampData read(TimestampData ignored) {
       long value = readLong();
       return TimestampData.fromLocalDateTime(
           Instant.ofEpochSecond(
-                  Math.floorDiv(value, 1000_000), Math.floorMod(value, 
1000_000) * 1000)
+                  Math.floorDiv(value, 1000_000), Math.floorMod(value, 
1000_000) * 1000L)

Review Comment:
   Just keep in mind you'll want to backport this to the previous Flink versions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to