amogh-jahagirdar commented on code in PR #10615:
URL: https://github.com/apache/iceberg/pull/10615#discussion_r1662929875
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -578,7 +578,8 @@ public Pair<Integer, TimeUnit> refresh(RESTClient client) {
.token(response.token())
.tokenType(response.issuedTokenType())
.build();
- this.headers = RESTUtil.merge(headers, authHeaders(config.token()));
+ Map<String, String> headersTmp = this.headers;
Review Comment:
While this is a temporary variable, typically in Iceberg we want to use
better names rather than abbreviations like "tmp". I would call this variable
`currentHeaders`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
