nastra commented on code in PR #10602: URL: https://github.com/apache/iceberg/pull/10602#discussion_r1661089067
########## gradle.properties: ########## @@ -24,5 +24,13 @@ systemProp.defaultSparkVersions=3.5 systemProp.knownSparkVersions=3.3,3.4,3.5 systemProp.defaultScalaVersion=2.12 systemProp.knownScalaVersions=2.12,2.13 +# enable the Gradle build cache - speeds up builds! +org.gradle.caching=true +# enable Gradle parallel builds org.gradle.parallel=true +# configure only necessary Gradle tasks +org.gradle.configureondemand=true +# explicitly disable the configuration cache +org.gradle.configuration-cache=false +#org.gradle.configuration-cache-problems=warn Review Comment: I'd remove this line as I don't see a good enough reason to keep it here ########## gradle.properties: ########## @@ -24,5 +24,13 @@ systemProp.defaultSparkVersions=3.5 systemProp.knownSparkVersions=3.3,3.4,3.5 systemProp.defaultScalaVersion=2.12 systemProp.knownScalaVersions=2.12,2.13 +# enable the Gradle build cache +org.gradle.caching=true +# enable Gradle parallel builds org.gradle.parallel=true +# configure only necessary Gradle tasks +org.gradle.configureondemand=true +# explicitly disable the configuration cache +org.gradle.unsafe.configuration-cache=false Review Comment: +1 on adding some reasoning as to why certain things are enabled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
