amogh-jahagirdar commented on code in PR #10605:
URL: https://github.com/apache/iceberg/pull/10605#discussion_r1659508615
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java:
##########
@@ -55,7 +55,7 @@ public class TestStreamScanSql extends CatalogTestBase {
private static final String TABLE = "test_table";
private static final FileFormat FORMAT = FileFormat.PARQUET;
- private TableEnvironment tEnv;
+ private volatile TableEnvironment tEnv;
@Override
protected TableEnvironment getTableEnv() {
Review Comment:
Not strictly required for correctness, more of a minor performance
improvement but you can add a temporary variable in `getTableEnv()` referencing
tEnv since in most cases tEnv will already be initialized. See
https://stackoverflow.com/a/3580658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
