ajantha-bhat commented on code in PR #8502:
URL: https://github.com/apache/iceberg/pull/8502#discussion_r1654742829
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -481,6 +488,13 @@ public static TableMetadata fromJson(String
metadataLocation, JsonNode node) {
statisticsFiles = ImmutableList.of();
}
+ List<PartitionStatisticsFile> partitionStatisticsFiles;
+ if (node.has(PARTITION_STATISTICS)) {
+ partitionStatisticsFiles =
partitionStatsFilesFromJson(node.get(PARTITION_STATISTICS));
+ } else {
+ partitionStatisticsFiles = ImmutableList.of();
+ }
+
Review Comment:
The way partition stats tracked and added to table metadata is same as
puffin files right now.
The stats are optional, so even if we lose it. Planner won't return wrong
query results.
However these stats can be helpful to improve query performance. We are
planning to provide a call procedure, compute partition stats. Which will check
the last snapshot that had partition stats and incrementally compute the stats
for remaining snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
