kevinjqliu commented on issue #751: URL: https://github.com/apache/iceberg-python/issues/751#issuecomment-2189740351
@ndrluis Thanks for the fix. It's passing all the unit tests I've collected for this issue. I'm still trying to wrap my head around why this works and if this is the proper fix. Do you mind adding an explanation, either here or in the PR? I thought `deepcopy` should return a different python object (contrasting with `copy`), returning `self` breaks the underlying assumption of `deepcopy`. Here's an example assertion that breaks ``` fixed8 = FixedType(8) assert id(fixed8) != id(deepcopy(fixed8)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
