sdd opened a new issue, #407: URL: https://github.com/apache/iceberg-rust/issues/407
Somehow, between my PR and @viirya's PR getting merged, we've ended up with the filter predicate being duplicated in the `TableScanBuilder` and the `TableScan`. See `predicates` and `filter`: https://github.com/apache/iceberg-rust/blob/adc5d200582f820ef408975bf541218aa9b07d64/crates/iceberg/src/scan.rs#L52-L56 https://github.com/apache/iceberg-rust/blob/adc5d200582f820ef408975bf541218aa9b07d64/crates/iceberg/src/scan.rs#L85-L91 https://github.com/apache/iceberg-rust/blob/adc5d200582f820ef408975bf541218aa9b07d64/crates/iceberg/src/scan.rs#L99-L103 And here in `TableScan`, `bound_predicates` and `filter`: https://github.com/apache/iceberg-rust/blob/adc5d200582f820ef408975bf541218aa9b07d64/crates/iceberg/src/scan.rs#L192-L196 The predicate pushdown uses one of these but the file plan uses another, which caused a lot of confusion when I was trying to track down why my queries were misbehaving! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
