findepi commented on code in PR #10523:
URL: https://github.com/apache/iceberg/pull/10523#discussion_r1643432562
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -563,6 +565,14 @@ protected boolean canInheritSnapshotId() {
return canInheritSnapshotId;
}
+ /**
+ * Can skip cleaning up uncommitted manifests if there are no retries as
retries can generate
+ * manifests that are not committed and orphaned
+ */
+ private boolean canSkipCleanupAfterCommitSuccess() {
+ return commitMetrics().attempts().value() <= 1;
Review Comment:
why not `== 0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
