nastra commented on code in PR #10500:
URL: https://github.com/apache/iceberg/pull/10500#discussion_r1642269689
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -643,10 +642,9 @@ public void testSingleCommitWithRewriteFailure() {
.when(spyRewrite)
.rewriteFiles(any(), argThat(failGroup));
- AssertHelpers.assertThrows(
- "Should fail entire rewrite if part fails",
- RuntimeException.class,
- () -> spyRewrite.execute());
+ Assertions.assertThatThrownBy(() -> spyRewrite.execute())
+ .as("Should fail entire rewrite if part fails")
+ .isInstanceOf(RuntimeException.class);
Review Comment:
all of these should have a `hasMessage()` check. You can use the Spark 3.5
version of that test class as a reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
